-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes] Add push
, pull
, and fetchStoreThemes
to Themes Package Public Exports
#4518
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1928 tests passing in 872 suites. Report generated by 🧪jest coverage report action from 967447b |
016e92c
to
5093dd0
Compare
be39e4f
to
3c883ab
Compare
push
, pull
, and fetchStoreThemes
to Themes Package Public Exports
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/url.d.ts@@ -5,11 +5,4 @@
* @returns True if the URL is valid, false otherwise.
* @throws An error if URL's constructor throws an error other than .
*/
-export declare function isValidURL(url: string): boolean;
-/**
- * Safely parse a string into a URL.
- *
- * @param url - The string to parse into a URL.
- * @returns A URL object if the parsing is successful, undefined otherwise.
- */
-export declare function safeParseURL(url: string): URL | undefined;
\ No newline at end of file
+export declare function isValidURL(url: string): boolean;
\ No newline at end of file
packages/cli-kit/dist/public/node/node-package-manager.d.ts@@ -293,17 +293,4 @@ export declare function addResolutionOrOverride(directory: string, dependencies:
* @param packageJSON - Package.json file to write.
*/
export declare function writePackageJSON(directory: string, packageJSON: PackageJson): Promise<void>;
-/**
- * Infers the package manager to be used based on the provided options and environment.
- *
- * This function determines the package manager in the following order of precedence:
- * 1. Uses the package manager specified in the options, if valid.
- * 2. Infers the package manager from the user agent string.
- * 3. Infers the package manager used for the global CLI installation.
- * 4. Defaults to 'npm' if no other method succeeds.
- *
- * @param optionsPackageManager - The package manager specified in the options (if any).
- * @returns The inferred package manager as a PackageManager type.
- */
-export declare function inferPackageManager(optionsPackageManager: string | undefined, env?: NodeJS.ProcessEnv): PackageManager;
export {};
\ No newline at end of file
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
3c883ab
to
bed0200
Compare
3e62d66
to
ef1393a
Compare
bed0200
to
36978af
Compare
ef1393a
to
e60b91f
Compare
36978af
to
b43121f
Compare
/snapit |
🫰✨ Thanks @karreiro! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jamesmengo!
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-advanced-edits/issues/346
WHAT is this pull request doing?
push,
pull, and
fetchStoreThemes` commands via the CLI packageHow to test your changes?
@shopify/theme
, such aspackages/app/src/cli/test.ts
push
,pull
, andfetchStoreThemes
push
andpull
to see the JSDoc for the args inside flagsGoogle.Chrome.-.Delete.Audio.+.Video.Recordings.Descript.Help.mp4
Template
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one
Checklist