Update with no ESlint rules

Shopify · Oct 18, 2024 · dbc775a · dbc775a
1 parent b56db43
commit dbc775a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/packages/theme/src/cli/utilities/theme-fs.test.ts b/packages/theme/src/cli/utilities/theme-fs.test.ts
@@ -293,7 +293,7 @@ describe('theme-fs', () => {
 
  // When
  const content = await readThemeFile(root, key)
- const contentJson = JSON.parse(content?.toString() || '')
+ const contentJson = JSON.parse(content?.toString() ?? '')
 
  // Then
  expect(contentJson).toEqual({

diff --git a/packages/theme/src/cli/utilities/theme-fs.ts b/packages/theme/src/cli/utilities/theme-fs.ts
@@ -99,13 +99,16 @@ export function mountThemeFileSystem(root: string, options?: ThemeFileSystemOpti
  .then(() => {
  switch (eventName) {
  case 'add':
- case 'change':
- return handleFileUpdate(eventName, themeId, adminSession, fileKey)
- case 'unlink':
- return handleFileDelete(themeId, adminSession, fileKey)
+ case 'change': {
+ handleFileUpdate(eventName, themeId, adminSession, fileKey)
+ return
+ }
+ case 'unlink': {
+ handleFileDelete(themeId, adminSession, fileKey)
+ }
  }
  })
- .catch((error) => {
+ .catch((error: unknown) => {
  outputWarn(`Error handling file event for ${fileKey}: ${error}`)
  })
  }
@@ -125,14 +128,14 @@ export function mountThemeFileSystem(root: string, options?: ThemeFileSystemOpti
  const previousChecksum = files.get(fileKey)?.checksum
 
  const contentPromise = read(fileKey).then(async () => {
- const file = files.get(fileKey)!
+ const file = files.get(fileKey)
 
- if (file.checksum !== previousChecksum) {
+ if (file?.checksum !== previousChecksum) {
  // Sync only if the file has changed
  unsyncedFileKeys.add(fileKey)
  }
 
- return file.value || file.attachment || ''
+ return file?.value ?? file?.attachment ?? ''
  })
 
  const syncPromise = contentPromise
@@ -154,6 +157,7 @@ export function mountThemeFileSystem(root: string, options?: ThemeFileSystemOpti
 
  return true
  })
+ // eslint-disable-next-line @typescript-eslint/use-unknown-in-catch-callback-variable
  .catch(createSyncingCatchError(fileKey, 'upload'))
 
  emitEvent(eventName, {
@@ -203,8 +207,8 @@ export function mountThemeFileSystem(root: string, options?: ThemeFileSystemOpti
  outputSyncResult('delete', fileKey)
  return true
  })
- .catch((error) => {
- createSyncingCatchError(fileKey, 'delete')(error)
+ .catch((error: unknown) => {
+ createSyncingCatchError(fileKey, 'delete')(error as Error)
  return false
  })