Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: intercept shop app redirect links #9

Closed
wants to merge 3 commits into from
Closed

wip: intercept shop app redirect links #9

wants to merge 3 commits into from

Conversation

cianbuckley
Copy link
Contributor

@cianbuckley cianbuckley commented Oct 2, 2023 •
edited
Loading

What are you trying to accomplish?

Fix for issue:

  • Customer completes checkout and lands on TYP
  • Customer clicks on "Download Shop App to track progress"
  • url is not intercepted as isExternal(url) has a targetFrame and has a navigation type of other
  • url opens in webview and then in turn is opens the App Store application
  • Web view is then locked in the redirect url, no back button, no swipe back.
  • Customer can no longer see the TYP

Before you deploy

  • I have added tests to support my implementation
  • I have read and agree with the contributing documentation readme
  • I have read and agree with the code of conduct documentation readme
  • I have updated any documentation related to these changes.
  • I have updated the README (if applicable).

@cianbuckley cianbuckley marked this pull request as ready for review October 3, 2023 08:18
@cianbuckley cianbuckley requested a review from a team as a code owner October 3, 2023 08:18
@cianbuckley cianbuckley deleted the intercept-shop-app-redirect branch October 19, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiftio kiftio kiftio approved these changes

@markmur markmur markmur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cianbuckley @markmur @kiftio