Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose "checkoutDidClickLink" handler, implement sensible defaults #6

Merged
merged 13 commits into from
Oct 2, 2023
Merged

Expose "checkoutDidClickLink" handler, implement sensible defaults #6

merged 13 commits into from
Oct 2, 2023

Conversation

cianbuckley
Copy link
Contributor

@cianbuckley cianbuckley commented Sep 28, 2023 •
edited
Loading

What are you trying to accomplish?

  • Adds sensible defaults to the checkout delegate (handle urls to open in safari, including email)
  • Adds a new optional delegate function checkoutDidClickLink

Before you deploy

  • I have added tests to support my implementation
  • I have read and agree with the contributing documentation readme
  • I have read and agree with the code of conduct documentation readme
  • I have updated any documentation related to these changes.
  • I have updated the README (if applicable).

@markmur markmur force-pushed the markmur/url-whitelist branch 2 times, most recently from b828a0c to 6e2b3e1 Compare September 29, 2023 08:39
@cianbuckley cianbuckley marked this pull request as ready for review September 29, 2023 08:46
@cianbuckley cianbuckley requested a review from a team as a code owner September 29, 2023 08:46
@markmur markmur changed the title Api change 2 Expose "checkoutDidClickLink" handler, implement sensible defaults Sep 29, 2023
@cianbuckley cianbuckley changed the base branch from markmur/url-whitelist to main September 29, 2023 09:03
@markmur markmur mentioned this pull request Sep 29, 2023
Closed
5 tasks
cocoahero
cocoahero reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@cocoahero cocoahero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are in a beta period and don't have a stable version yet, I would argue that we should strive for our ideal API now which would be just a single checkoutDidClickLink callback.

Sources/ShopifyCheckout/CheckoutDelegate.swift Outdated Show resolved Hide resolved
@cianbuckley cianbuckley merged commit f4982c4 into main Oct 2, 2023
2 checks passed
@cianbuckley cianbuckley deleted the api-change-2 branch October 2, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocoahero cocoahero cocoahero left review comments

@kiftio kiftio kiftio approved these changes

@markmur markmur markmur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cianbuckley @cocoahero @markmur @kiftio