Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused close bridge event #43

Merged
merged 1 commit into from
Oct 25, 2023
Merged

remove unused close bridge event #43

merged 1 commit into from
Oct 25, 2023

Conversation

kiftio
Copy link
Contributor

@kiftio kiftio commented Oct 25, 2023

What are you trying to accomplish?

The close event was required when the SDK used a web header, and needed to listen for close events from web. Now we have a native header, the event is unused and can be removed.

Before you deploy

  • I have added tests to support my implementation
  • I have read and agree with the contributing documentation readme
  • I have read and agree with the code of conduct documentation readme
  • I have updated any documentation related to these changes.
  • I have updated the README (if applicable).

@kiftio kiftio requested a review from a team as a code owner October 25, 2023 12:07
@kiftio kiftio merged commit fb44fb2 into main Oct 25, 2023
4 checks passed
@kiftio kiftio deleted the dk/remove-close-event branch October 25, 2023 12:36
markmur pushed a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants