return an error when checkout 404s. indicate to client that it may be… #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cianbuckley
force-pushed
the
error-on-checkout-liquid
branch
from
a058e24 to
178a52c
Compare
cianbuckley
commented
Oct 31, 2023
markmur
approved these changes
Oct 31, 2023
Comment on lines
150
to
151
| case 404: | ||
| viewDelegate?.checkoutViewDidFailWithError(error: .sdkError(underlying: CheckoutLiquidError.unmigratedCheckoutError(message: "The checkout url provided has resulted in an error. The store is still using checkout.liquid, whereas the checkout SDK only supports checkout with extensibility."))) |
There was a problem hiding this comment.
Is it a guarantee that 404 = unmigrated? What if the cart/checkout simply doesn't exist?
There was a problem hiding this comment.
It's just not great is it.. I'll move the needle on a more appropriate status code response over the coming days
cianbuckley
force-pushed
the
error-on-checkout-liquid
branch
from
667b005 to
f557ade
Compare
markmur
pushed a commit
that referenced
this pull request
Nov 7, 2023
#42) * return an error when checkout 404s. indicate to client that it may be due to store using checkout.liquid * remove references to 404 favouring client facing error * favour flattened error hierarchy * linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… due to store using checkout.liquid
What are you trying to accomplish?
When a shop is still on checkout.liquid, server returns a 404 as the sdk is not compatible with single page checkout. That's not been very clear to users of the sdk, so this PR throws a more descriptive stack trace and documents it
Before you deploy