Show native loading spinner only on initial load #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmur
reviewed
Oct 24, 2023
| @@ -25,7 +25,6 @@ import UIKit | |||
| import WebKit | |||
|
|
|||
| protocol CheckoutViewDelegate: AnyObject { | |||
| func checkoutViewDidStartNavigation() | |||
There was a problem hiding this comment.
We will most likely need this method when we implement the next spinner solution so I would leave this delegate method for now, just remove the default behaviour here
| } | ||
| spinner.startAnimating() |
There was a problem hiding this comment.
Wouldn't we want to do this under line 110? Does this work with preloading?
|
@markmur is actively working on the SDK Loading issue and will take over this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Shopify/checkout-sdk-issues/issues/196
Closes https://github.com/Shopify/checkout-sdk-issues/issues/207
What are you trying to accomplish?
Instead of displayed the native spinner on every navigation, we should show the native loading spinner only on initial load.
23-29-d0iko-ei3m2.mp4
Before you deploy