Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Theming] Update theming for web_default theme option in sample app #36

Merged
merged 4 commits into from
Oct 20, 2023
Merged

[Theming] Update theming for web_default theme option in sample app #36

merged 4 commits into from
Oct 20, 2023

Conversation

markmur
Copy link
Contributor

@markmur markmur commented Oct 20, 2023 •
edited
Loading

What are you trying to accomplish?

Before you deploy

  • I have added tests to support my implementation
  • I have read and agree with the contributing documentation readme
  • I have read and agree with the code of conduct documentation readme
  • I have updated any documentation related to these changes.
  • I have updated the README (if applicable).

@markmur markmur self-assigned this Oct 20, 2023
@markmur markmur force-pushed the markmur/update-web-default-colors branch from b4a4c05 to 662976a Compare October 20, 2023 16:19
@markmur markmur marked this pull request as ready for review October 20, 2023 16:38
@markmur markmur requested a review from a team as a code owner October 20, 2023 16:38
@markmur markmur force-pushed the markmur/update-web-default-colors branch from 163cbac to eb7c451 Compare October 20, 2023 16:40
@markmur markmur requested a review from cocoahero October 20, 2023 16:40
@markmur markmur force-pushed the markmur/update-web-default-colors branch from eb7c451 to c27992d Compare October 20, 2023 16:44
@markmur markmur force-pushed the markmur/update-web-default-colors branch from b0893fa to 9e049e2 Compare October 20, 2023 16:49
@markmur markmur force-pushed the markmur/update-web-default-colors branch from 9e049e2 to 79a834e Compare October 20, 2023 16:50
@markmur markmur merged commit 38f217c into main Oct 20, 2023
4 checks passed
@markmur markmur deleted the markmur/update-web-default-colors branch October 20, 2023 16:54
markmur added a commit that referenced this pull request Nov 7, 2023
@markmur
[Theming] Update theming for web_default theme option in sample app (#36
92931ff 
)

* [Theming] Update theming for web_default theme option in sample app

* Use .stop icon on .web theme

* Make the X icon smaller

* Remove unused gradient asset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocoahero cocoahero cocoahero approved these changes

Assignees

@markmur markmur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markmur @cocoahero