Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: README install steps #35

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: README install steps #35

merged 1 commit into from
Oct 20, 2023

Conversation

ocastx
Copy link
Contributor

@ocastx ocastx commented Oct 20, 2023

What are you trying to accomplish?

Xcode 15 seems to have introduced new setting names

CleanShot 2023-10-20 at 13 16 50@2x

Before you deploy

  • I have added tests to support my implementation
  • I have read and agree with the contributing documentation readme
  • I have read and agree with the code of conduct documentation readme
  • I have updated any documentation related to these changes.
  • I have updated the README (if applicable).

@ocastx ocastx requested a review from a team as a code owner October 20, 2023 11:17
cianbuckley
cianbuckley approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@cianbuckley cianbuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. LGTM

@markmur
Copy link
Contributor

markmur commented Oct 20, 2023

Thanks for the contribution @ocastx!

@markmur markmur merged commit 5e39326 into Shopify:main Oct 20, 2023
4 checks passed
@ocastx ocastx deleted the xcode-renaming branch October 20, 2023 15:03
markmur pushed a commit that referenced this pull request Nov 7, 2023
@ocastx @markmur
fix: README install steps (#35)
6b9feb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cianbuckley cianbuckley cianbuckley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ocastx @markmur @cianbuckley