Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split sdk and sample tests #29

Merged
merged 6 commits into from
Oct 19, 2023
Merged

split sdk and sample tests #29

merged 6 commits into from
Oct 19, 2023

Conversation

kiftio
Copy link
Contributor

@kiftio kiftio commented Oct 19, 2023

What are you trying to accomplish?

Splits tests, so that they can be parallelised and so that the README badge can just look at SDK test status
Introduces some test step duplication that'd be good to tidy up.

Before you deploy

  • I have added tests to support my implementation
  • I have read and agree with the contributing documentation readme
  • I have read and agree with the code of conduct documentation readme
  • I have updated any documentation related to these changes.
  • I have updated the README (if applicable).

@caution-tape-bot
Copy link

👋 It seems that this PR is adding a GitHub Action workflow that looks a lot like a CI step.

If your repository is a prodkit repository, then this is fine. Please ignore the rest of this comment.

If your repository already uses Shopify Build CI or Shipit CD, then please make sure to consider whether you are splitting your CI/CD pipelines and jobs in a way that makes sense and is easy to maintain.

If this workflow change is not introducing a CI step, then feel free to ignore this comment.

For more details and explanation, click to expand...

Shopify Build used to be the required platform for CI at Shopify, but we are now allowing GitHub Actions to be used for this purpose, especially if the repo is using ProdKit for deploys.

But it's not always a good idea to split your CI for a repo or service between different systems at once. We want to make sure that developers think about the potential maintenance costs of maintaining multiple systems before doing so.

For more information, see GitHub Actions on Vault.

Note that this message is based on a simple regex detection, and may not always be accurate. If your action is not a CI step, and is already running on shopify-ubuntu-latest or similar, feel free to ignore this message.

If your repository is intended to become Public later, please use runs-on: shopify-ubuntu-latest for now and ignore the rest of this comment. Though if you need to use Ubuntu 20.04 only, you would need to use runs-on: shopify-ubuntu-20.04. Or runs-on: shopify-ubuntu-latest-2 for Ubuntu 22.04.


This comment was added by the GitHubActions::CiStep Caution Tape Bot rule.
View the source of this rule in Services DB

@caution-tape-bot
Copy link

👋 It seems that this PR is adding, or editing, a GitHub Action workflow that is supposed to run on macOS machines.

MacOS runners can be more expensive and less performant than MacStadium with Shopify Build.

This is OK, but please make sure to consider whether your workflow will have a long runtime or needs extra compute, and whether they may be more suited to running in a Shopify Build pipeline.


This comment was added by the GitHubActions::MacWorkflow Caution Tape Bot rule.
View the source of this rule in Services DB

@kiftio kiftio merged commit ae92acb into main Oct 19, 2023
@kiftio kiftio deleted the dk/split-tests branch October 19, 2023 12:17
markmur pushed a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants