Rewrite the MobileBuyIntegration sample controllers in SwiftUI #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmur
force-pushed
the
markmur/rewrite-to-swiftui
branch
3 times, most recently
from
8729f84 to
b55f14b
Compare
markmur
force-pushed
the
markmur/rewrite-to-swiftui
branch
from
b55f14b to
4523601
Compare
markmur
force-pushed
the
markmur/rewrite-to-swiftui
branch
from
6a5dbda to
21e85dc
Compare
markmur
commented
Nov 25, 2024
| INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents = YES; | ||
| INFOPLIST_KEY_UILaunchStoryboardName = LaunchScreen; | ||
| INFOPLIST_KEY_UISupportedInterfaceOrientations = UIInterfaceOrientationPortrait; | ||
| INFOPLIST_KEY_UISupportedInterfaceOrientations_iPad = "UIInterfaceOrientationLandscapeLeft UIInterfaceOrientationLandscapeRight UIInterfaceOrientationPortrait UIInterfaceOrientationPortraitUpsideDown"; | ||
| IPHONEOS_DEPLOYMENT_TARGET = 13.0; |
There was a problem hiding this comment.
iOS 13 is obsolete and no longer receiving security updates
markmur
force-pushed
the
markmur/rewrite-to-swiftui
branch
6 times, most recently
from
2bc019f to
dec9a3d
Compare
markmur
force-pushed
the
markmur/rewrite-to-swiftui
branch
from
dec9a3d to
ed603d9
Compare
markmur
force-pushed
the
markmur/rewrite-to-swiftui
branch
from
811428d to
39d48bb
Compare
kiftio
approved these changes
Nov 26, 2024
| @@ -29,6 +29,10 @@ extension Storefront.MoneyV2 { | |||
| let formatter = NumberFormatter() | |||
| formatter.numberStyle = .currency | |||
| formatter.currencyCode = currencyCode.rawValue | |||
| return formatter.string(from: NSDecimalNumber(decimal: amount)) | |||
| return isFree() ? "Free" : formatter.string(from: NSDecimalNumber(decimal: amount)) | |||
There was a problem hiding this comment.
Gonna steal this for android 👍
| @State private var product: Storefront.Product | ||
| @State private var handle: String? | ||
| @State private var loading = false | ||
| @State private var imageLoaded: Bool = false |
There was a problem hiding this comment.
Can't tell if it's Github or the indentation is actually a bit off?
There was a problem hiding this comment.
Yeah it's actually off. #247 will fix it
| Text(product.description) | ||
| .font(.body) | ||
| .foregroundColor(.gray) | ||
| .lineLimit(descriptionExpanded ? 10 : 3) |
There was a problem hiding this comment.
I think 10 for the expanded text is still bit too low for some of the products in the store (e.g. looking at Bird of paradise)
There was a problem hiding this comment.
Yeah, probably. I'll account for this in the full redesign task
| guard let variant = product.variants.nodes.first else { return } | ||
|
|
||
| loading = true | ||
| let start = Date() |
There was a problem hiding this comment.
Continuous clock looks interesting.. Although I'm not sure how easy it is to use with callbacks.
let clock = ContinuousClock()
let elapsed = clock.measure {
someWork()
}
| Toggle("Handle Cart URLs", isOn: $appConfiguration.universalLinks.cart) | ||
| Toggle("Handle Product URLs", isOn: $appConfiguration.universalLinks.products) | ||
| Toggle("Handle all Universal Links", isOn: $appConfiguration.universalLinks.handleAllURLsInApp) | ||
| Toggle("Handle Checkout URLs", isOn: $config.universalLinks.checkout) |
There was a problem hiding this comment.
We also need to catch android up here at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
plant-sample-app.mp4
Before you merge
Important