-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and expand README #15
Conversation
- Wordsmithing / expanding a few sessions - Shuffled order of sections - Expanded identity + auth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Looks great, I've added some minor suggestions. I've also opened a PR in the Android repo to incorporate these changes there
Co-authored-by: Dan K <[email protected]>
Co-authored-by: Cian Buckley <[email protected]> Co-authored-by: Jonathan Baker <[email protected]>
- update description to match language in shopify.dev - revert back to `checkoutURL` - other minor tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding that in! Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads great to me! 📖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor adjustments.
Co-authored-by: Ilya Grigorik <[email protected]>
Co-authored-by: Ilya Grigorik <[email protected]>
Co-authored-by: Ilya Grigorik <[email protected]>
Update and expand README - Shuffled order of sections - Update code examples - Expanded identity + auth - Web pixel/behavioral analytics callout --------- Co-authored-by: Dan K <[email protected]> Co-authored-by: Cian Buckley <[email protected]> Co-authored-by: Jonathan Baker <[email protected]> Co-authored-by: Mark Murray <[email protected]>
What are you trying to accomplish?