Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and expand README #15

Merged
merged 15 commits into from
Oct 18, 2023
Merged

Update and expand README #15

merged 15 commits into from
Oct 18, 2023

Conversation

igrigorik
Copy link
Contributor

What are you trying to accomplish?

  • Wordsmithing / expanding a few sessions
  • Shuffled order of sections
  • Expanded identity + auth

- Wordsmithing / expanding a few sessions
- Shuffled order of sections
- Expanded identity + auth
@igrigorik igrigorik requested a review from a team as a code owner October 9, 2023 18:13
Copy link
Contributor

@kiftio kiftio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Looks great, I've added some minor suggestions. I've also opened a PR in the Android repo to incorporate these changes there

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
igrigorik and others added 2 commits October 10, 2023 09:40
Co-authored-by: Cian Buckley <[email protected]>
Co-authored-by: Jonathan Baker <[email protected]>
- update description to match language in shopify.dev
- revert back to `checkoutURL`
- other minor tweaks
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TejasM TejasM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that in! Looks good to me.

Copy link
Contributor

@markmur markmur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads great to me! 📖

README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor adjustments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
markmur and others added 3 commits October 17, 2023 15:43
Co-authored-by: Ilya Grigorik <[email protected]>
Co-authored-by: Ilya Grigorik <[email protected]>
Co-authored-by: Ilya Grigorik <[email protected]>
@igrigorik igrigorik merged commit 06516ae into main Oct 18, 2023
3 checks passed
@igrigorik igrigorik deleted the igrigorik-sdk-ios-readme branch October 18, 2023 19:16
markmur added a commit that referenced this pull request Nov 7, 2023
Update and expand README
- Shuffled order of sections
- Update code examples
- Expanded identity + auth
- Web pixel/behavioral analytics callout

---------

Co-authored-by: Dan K <[email protected]>
Co-authored-by: Cian Buckley <[email protected]>
Co-authored-by: Jonathan Baker <[email protected]>
Co-authored-by: Mark Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants