[POC] Implement SFSafariViewController as fallback when checkoutDidFail #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmur
commented
Mar 5, 2024
|
|
||
| throw NSError(domain: "com.shopify", code: 1, userInfo: [NSLocalizedDescriptionKey: "Fake Error"]) |
There was a problem hiding this comment.
Intentionally throwing an error here anytime we receive a bridge event
markmur
force-pushed
the
markmur/graceful-fallback-poc
branch
from
502de3c to
e51b56f
Compare
markmur
changed the title
markmur
force-pushed
the
markmur/graceful-fallback-poc
branch
4 times, most recently
from
201a903 to
092cb3e
Compare
markmur
force-pushed
the
markmur/graceful-fallback-poc
branch
from
092cb3e to
2e7d1ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
POC-SFSafariViewController.1.mp4
Before you merge
Important
Checklist for releasing a new version
podspecfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.