Return View from present method #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmur
commented
Mar 4, 2024
| from.present(CheckoutViewController(checkout: url, delegate: delegate), animated: true) | ||
| } | ||
|
|
||
| public func presentRepresentable(checkout url: URL, delegate: CheckoutDelegate? = nil) { |
There was a problem hiding this comment.
As far as I can tell this is not used at all
cocoahero
reviewed
Mar 5, 2024
markmur
force-pushed
the
markmur/return-view
branch
from
83c43c6 to
efb8dfa
Compare
markmur
force-pushed
the
v2
branch
3 times, most recently
from
8daee69 to
def03dd
Compare
markmur
force-pushed
the
markmur/return-view
branch
from
efb8dfa to
f41af42
Compare
markmur
force-pushed
the
markmur/return-view
branch
5 times, most recently
from
57ee060 to
331a8d1
Compare
markmur
force-pushed
the
v2
branch
7 times, most recently
from
cdd337a to
a11c02a
Compare
markmur
force-pushed
the
markmur/return-view
branch
from
331a8d1 to
1fb518f
Compare
kiftio
pushed a commit
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Returns the
CheckoutViewControllerfrom thepresentmethodBefore you merge
Important
I've added tests to support my implementationI've updated the README.Checklist for releasing a new version
podspecfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.