Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web-pixels documentation #124

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

TejasM
Copy link
Contributor

@TejasM TejasM commented Jan 29, 2024

Current reasons for neutering have to do with user privacy but only reason we don't fire events is we don't have a way to consume consent. Removing the statement to make it easy for us to update in the future.

@TejasM TejasM requested a review from a team as a code owner January 29, 2024 14:54
@TejasM TejasM requested review from LouisMVA, markmur and kiftio January 29, 2024 14:56
README.md Outdated Show resolved Hide resolved
Copy link

@LouisMVA LouisMVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Mark's one formatting change

README.md Outdated
@@ -264,9 +264,9 @@ extension MyViewController: ShopifyCheckoutSheetKitDelegate {

App developers can use [lifecycle events](#monitoring-the-lifecycle-of-a-checkout-session) to monitor and log the status of a checkout session.

**To safeguard user privacy, Web Pixel events will not be dispatched from within the Checkout webview.** Instead, these events will be relayed back to your application through the checkoutDidEmitWebPixelEvent delegate hook. The responsibility then falls on the application developer to ensure adherence to Apple privacy protocols before disseminating these events to third-party providers.
**For behavioural monitoring, Checkout [Web Pixel events](https://shopify.dev/docs/api/web-pixels-api/standard-events) will be relayed back to your application through the `checkoutDidEmitWebPixelEvent` delegate hook. The responsibility then falls on the application developer to ensure adherence to Apple's privacy policy and local regulations like GDPR and ePrivacy directive before disseminating these events to first-party and third-party systems.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We link to standard events, but custom events will also be relayed. In case we think that's worth noting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equivalent android PR here - Shopify/checkout-sheet-kit-android#58

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point, let me update it to include mention of both.

@markmur markmur force-pushed the update-web-pixels-documentation branch from 1faa424 to 02ae09d Compare January 30, 2024 14:12
Current reasons for neutering have to do with user privacy but only reason we don't fire events is we don't have a way to consume consent. Removing the statement to make it easy for us to update in the future.
@markmur markmur force-pushed the update-web-pixels-documentation branch from 02ae09d to b4e5f02 Compare January 30, 2024 14:13
@markmur markmur merged commit bccec32 into main Jan 30, 2024
6 checks passed
@markmur markmur deleted the update-web-pixels-documentation branch January 30, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants