-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update web-pixels documentation #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with Mark's one formatting change
README.md
Outdated
@@ -264,9 +264,9 @@ extension MyViewController: ShopifyCheckoutSheetKitDelegate { | |||
|
|||
App developers can use [lifecycle events](#monitoring-the-lifecycle-of-a-checkout-session) to monitor and log the status of a checkout session. | |||
|
|||
**To safeguard user privacy, Web Pixel events will not be dispatched from within the Checkout webview.** Instead, these events will be relayed back to your application through the checkoutDidEmitWebPixelEvent delegate hook. The responsibility then falls on the application developer to ensure adherence to Apple privacy protocols before disseminating these events to third-party providers. | |||
**For behavioural monitoring, Checkout [Web Pixel events](https://shopify.dev/docs/api/web-pixels-api/standard-events) will be relayed back to your application through the `checkoutDidEmitWebPixelEvent` delegate hook. The responsibility then falls on the application developer to ensure adherence to Apple's privacy policy and local regulations like GDPR and ePrivacy directive before disseminating these events to first-party and third-party systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We link to standard events, but custom events will also be relayed. In case we think that's worth noting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Equivalent android PR here - Shopify/checkout-sheet-kit-android#58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good point, let me update it to include mention of both.
1faa424
to
02ae09d
Compare
Current reasons for neutering have to do with user privacy but only reason we don't fire events is we don't have a way to consume consent. Removing the statement to make it easy for us to update in the future.
02ae09d
to
b4e5f02
Compare
Current reasons for neutering have to do with user privacy but only reason we don't fire events is we don't have a way to consume consent. Removing the statement to make it easy for us to update in the future.