Show loading spinner only on initial load

Shopify · Oct 23, 2023 · 3324974 · 3324974
1 parent ee076fb
commit 3324974
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 17 deletions.
diff --git a/Sources/ShopifyCheckout/CheckoutView.swift b/Sources/ShopifyCheckout/CheckoutView.swift
@@ -25,7 +25,6 @@ import UIKit
 import WebKit
 
 protocol CheckoutViewDelegate: AnyObject {
-	func checkoutViewDidStartNavigation()
 	func checkoutViewDidCompleteCheckout()
 	func checkoutViewDidFinishNavigation()
 	func checkoutViewDidClickLink(url: URL)
@@ -156,10 +155,6 @@ extension CheckoutView: WKNavigationDelegate {
 		return .allow
 	}
 
-    func webView(_ webView: WKWebView, didStartProvisionalNavigation navigation: WKNavigation!) {
-        viewDelegate?.checkoutViewDidStartNavigation()
-    }
-
     func webView(_ webView: WKWebView, didFinish navigation: WKNavigation!) {
         viewDelegate?.checkoutViewDidFinishNavigation()
 	}

diff --git a/Sources/ShopifyCheckout/CheckoutViewController.swift b/Sources/ShopifyCheckout/CheckoutViewController.swift
@@ -111,8 +111,8 @@ class CheckoutViewController: UIViewController, UIAdaptivePresentationController
 			checkoutView.load(checkout: checkoutURL)
 		} else if checkoutView.isLoading && initialNavigation {
 			checkoutView.alpha = 0
-			spinner.startAnimating()
 		}
+		spinner.startAnimating()
 	}
 
 	@IBAction internal func close() {
@@ -130,13 +130,6 @@ class CheckoutViewController: UIViewController, UIAdaptivePresentationController
 }
 
 extension CheckoutViewController: CheckoutViewDelegate {
-
-	func checkoutViewDidStartNavigation() {
-		if initialNavigation {
-			spinner.startAnimating()
-		}
-	}
-
 	func checkoutViewDidFinishNavigation() {
 		spinner.stopAnimating()
 		initialNavigation = false

diff --git a/Tests/ShopifyCheckoutTests/Mocks/MockCheckoutViewDelegate.swift b/Tests/ShopifyCheckoutTests/Mocks/MockCheckoutViewDelegate.swift
@@ -37,10 +37,6 @@ class MockCheckoutViewDelegate: CheckoutViewDelegate {
 
 	var didFailWithErrorExpectation: XCTestExpectation?
 
-	func checkoutViewDidStartNavigation() {
-		didStartNavigationExpectation?.fulfill()
-	}
-
 	func checkoutViewDidCompleteCheckout() {
 		didCompleteCheckoutExpectation?.fulfill()
 	}