This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Nth of type #604
Open
Nth of type #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Shopify Apps modify the grid using script tags injected between divs. nth-child does include script tags whereas nth-of-type does not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bold Apps Customer Specific Pricing app injects
<script>tags between<div>tags on the product grid. Thenth-childpseudo-class did not appear to select the appropriate<div>tag because of the injection of<script>tags. When I switched to usingnth-of-type, the issue was resolved.Given the possibility that other apps may also modify the grid, using
nth-of-typereduces the chances of other users encountering this issue.