-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add DB migration & endpoint to download missing TMDB People #1203
fix: add DB migration & endpoint to download missing TMDB People #1203
Conversation
Optionally allows for the complete removal of the person/cast/crew entry if unable to update it.
This is only a workaround to the original issue... but I needed this to fix my own database so figured that a PR wouldn't hurt, even if it gets closed. In my own testing, I encountered an NRE for a person ID which appears to no longer exist on TMDB, hence this being the only thing that's caught. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would do better as a db migration once the core issue is fixed.
Confirming that this works fine™ in my SQLite setup. I removed ~125 TMDB_Person records prior to launching the server, and after the migration occured, hitting the new endpoint resulted in no missing records being found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things before we merge things. If you're unsure about something then you can add a comment here on GH or ask on discord.
…ues. Misc: Remove parallelization in `/TMDB/Person/DownloadMissing` endpoint
Updated in line with feedback now. One issue I can forsee... If a TMDB show has been updated in the last calendar hour when the migration runs, it may not update as expected in the event TMDB returns N.B. I've used |
Just run it with force refresh set to true.
Personally, i would had just used peole. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one nit-pick left, but I'll just fix that through GH.
Optionally allows for the complete removal of the person/cast/crew entry if unable to update it.
This allows for a user-driven resolution to the problems that issue #1202 demonstrate.