Plex webhook episode detection for non-episode videos #1126
Conversation
LordFlashmeow
force-pushed
the
master
branch
2 times, most recently
from
7209b1d to
0a3f36d
Compare
| @@ -60,20 +62,29 @@ public ActionResult WebhookPost([FromForm] [ModelBinder(BinderType = typeof(Plex | |||
| } | |||
|
|
|||
| _logger.LogTrace($"{payload.Event}: {payload.Metadata?.Guid}"); | |||
|
|
|||
| var user = User; | |||
| user ??= RepoFactory.JMMUser.GetAll().FirstOrDefault(u => payload.Account.Title.FindIn(u.GetPlexUsers())); | |||
There was a problem hiding this comment.
Instead of passing the user around and having additional parameters, would it be possibly better to have a cached JMMUser property on the payload?
There was a problem hiding this comment.
How would that be done? (Sorry, I haven't worked with C# before)
| var key = metadata.Key.Split("/").LastOrDefault(); // '/library/metadata/{key}' | ||
|
|
||
| var plexEpisode = (SVR_Episode)GetPlexEpisodeData(key, user); | ||
| var episode = plexEpisode?.AnimeEpisode; |
There was a problem hiding this comment.
Can we add this with a guard against people not having a valid plex connection?
The original design was that the webhook did not require user plex login, so it was entirely working off it's own data.
Happy to add this in, but I think it should be at least guarded to allow for users to not have their own plex config.
There was a problem hiding this comment.
Can you clarify the scenario you're describing? The user has plex webhooks enabled, but hasn't linked their plex account to Shoko?
If that's the case, I suppose I could fall back original behavior of only matching episodes.
| /// <returns>the AnimeEpisode given the file information</returns> | ||
| public SVR_AnimeEpisode GetByFilename(string name) | ||
| public SVR_AnimeEpisode GetByFilename(string name, long? size = null) |
There was a problem hiding this comment.
Consider renaming this, or adding an extra helper to make this clearer.
There was a problem hiding this comment.
I split it into 2 functions, GetByFilename(string name) and GetByFilenameAndSize(string name, long size) is that suitable?
|
Sorry for the delay reviewing this in proper, only got internet proper today. |
Use title + episode number (or TVDB season + episode #) for non-Episode type videos.
Co-authored-by: Cazzar <[email protected]>
|
@LordFlashmeow can you update your PR please and resolve conflicts. |
Use title + episode number (or TVDB season + episode #) for non-Episode type videos.Use Plex API to fetch the filename of the watched video file (for non-episode type videos).
This should allow the Plex webhook to mark specials and other video types as watched.
There is a corner case where the user has multiple episodes with the same file name in a series, handling that is TBD.