refactor: only check if a zip is attached

only check if a zip is attached, as stated in the pre-existing comment.
ShokoAnime · Oct 20, 2024 · 32ae459 · 32ae459
1 parent 808d7ae
commit 32ae459
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/Shoko.Server/API/WebUI/WebUIHelper.cs b/Shoko.Server/API/WebUI/WebUIHelper.cs
@@ -71,10 +71,8 @@ public static void GetUrlAndUpdate(string tagName)
         foreach (var assets in release.assets)
         {
             // We don't care what the zip is named, only that it is attached.
-            // This is because we changed the signature from "latest.zip" to
-            // "Shoko-WebUI-{obj.tag_name}.zip" in the upgrade to web ui v2
             string fileName = assets.name;
-            if (fileName == "latest.zip" || fileName == $"Shoko-WebUI-{release.tag_name}.zip")
+            if (Path.GetExtension(fileName) is ".zip")
             {
                 url = assets.browser_download_url;
                 break;

diff --git a/Shoko.Server/API/v3/Controllers/WebUIController.cs b/Shoko.Server/API/v3/Controllers/WebUIController.cs
@@ -483,10 +483,8 @@ public ActionResult<ComponentVersion> LatestWebUIVersion([FromQuery] ReleaseChan
                         foreach (var asset in release.assets)
                         {
                             // We don't care what the zip is named, only that it is attached.
-                            // This is because we changed the signature from "latest.zip" to
-                            // "Shoko-WebUI-{obj.tag_name}.zip" in the upgrade to web ui v2
                             string fileName = asset.name;
-                            if (fileName == "latest.zip" || fileName == $"Shoko-WebUI-{tagName}.zip")
+                            if (Path.GetExtension(fileName) is ".zip")
                             {
                                 var tag = WebUIHelper.DownloadApiResponse($"git/ref/tags/{tagName}");
                                 string commit = tag["object"].sha;