Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigating responsive in web #752

Merged
merged 14 commits into from
Jan 13, 2024

Conversation

duehoa1211
Copy link
Contributor

@duehoa1211 duehoa1211 commented Jan 4, 2024

  • Mitigating collection screen responsive
    1. Overview tab ✅
    2. Episode tab ✅
    3. Credit tab ✅
    4. Images tab ✅
    5. Tags tab ✅
    6. Files tab ✅
  • Mitigating utilities screen reponsive

@duehoa1211 duehoa1211 changed the title Mitigating responsive in web Mitigating responsive in web (WIP) Jan 4, 2024
@duehoa1211 duehoa1211 marked this pull request as ready for review January 6, 2024 13:33
@duehoa1211 duehoa1211 changed the title Mitigating responsive in web (WIP) Mitigating responsive in web Jan 6, 2024
@duehoa1211
Copy link
Contributor Author

Link to #745

@ElementalCrisis
Copy link
Member

ElementalCrisis commented Jan 6, 2024

Your changes created new issues for the options bar at lower res now.

image
image
image

Review the mockups in Figma (check Components page) as at 1280 and below, the search bar is always shown and takes up the entire width.

The button and padding styling have been changed as well. I imagine it was changed to make the options fit, however, if they don't fit, they get put into the drop-down. The Gap between items on the option bar is always 1rem, otherwise it looks crowded.

Also, the drop-down button does not only appear when you search. Search is an overlay that if the options are present, it covers. If the options are in a dropdown, it would always be visible.

Correct
image

Your Version
image

@ElementalCrisis
Copy link
Member

@duehoa1211 duehoa1211 force-pushed the update-styles branch 4 times, most recently from ef0e71a to 085de11 Compare January 12, 2024 02:10
src/components/Input/Input.tsx Outdated Show resolved Hide resolved
@ElementalCrisis ElementalCrisis merged commit c260daa into ShokoAnime:master Jan 13, 2024
3 checks passed
@duehoa1211 duehoa1211 deleted the update-styles branch January 14, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants