-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mitigating responsive in web #752
Conversation
b9ce78f
to
1e857f5
Compare
Link to #745 |
Your changes created new issues for the options bar at lower res now. Review the mockups in Figma (check Components page) as at 1280 and below, the search bar is always shown and takes up the entire width. The button and padding styling have been changed as well. I imagine it was changed to make the options fit, however, if they don't fit, they get put into the drop-down. The Gap between items on the option bar is always 1rem, otherwise it looks crowded. Also, the drop-down button does not only appear when you search. Search is an overlay that if the options are present, it covers. If the options are in a dropdown, it would always be visible. |
Here's an example when the options bar still fits at a lower browser res. Example when it does not. |
ef0e71a
to
085de11
Compare
085de11
to
e568ced
Compare
1. Overview tab ✅
2. Episode tab ✅
3. Credit tab ✅
4. Images tab ✅
5. Tags tab ✅
6. Files tab ✅