Recently Imported Episodes Panel: Guarantee a Unique Key Per Element #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case where duplicate keys may end up used in instances where a regular episode and an O episode is imported. Take my case for example:
Both O1 and O2 have the file IDs 10126 and 10127 respectively. However E1 would have both 10126 and 10127 linked to it. So when rendering O1, O2, and both instances of E1, duplicate keys will be used since it was based on the FileID.
The following warning will be displayed when running the code in development mode as a result:
This pull request should fix this issue by setting the key to EpisodeID-FileID instead of just to FileID.