QoL Improvements #654
QoL Improvements #654
Conversation
… Importing Multiples.
src/pages/collection/Series.tsx
Outdated
| <> | ||
| <Link | ||
| className="font-semibold text-panel-text-primary" | ||
| to={`/webui/collection/group/${series.IDs?.ParentGroup}`} |
There was a problem hiding this comment.
I think ?.ParentGroup check needs to be moved into group.Size > 1 condition otherwise you will be rendering a broken link which doesn't make a lot of sense.
There was a problem hiding this comment.
group will be empty if ParentGroup doesn't exist because the query will be skipped. So it doesn't matter.
There was a problem hiding this comment.
I mean if you anticipate that ${series.IDs?.ParentGroup} might be null then just move it to the line 109 and don't try to render a link at all if you are unable to make a valid route anyways.
There was a problem hiding this comment.
I don't think the optional chaining there is needed as every series will always have a parent group. Its why I added the group.Size check in the first place since without it, you could go into the group for single series.
There was a problem hiding this comment.
There, I fixed it 👍
IDs will always exist so there was no point in putting the ? anyway
No description provided.