Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contibution.md file #707

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Parth4git
Copy link

@Parth4git Parth4git commented Oct 17, 2024

I have added contribution.md file which has all necessary information needed for doing any contribution in this repo.
kindly review my PR. @HuanzhiMao

@HuanzhiMao HuanzhiMao linked an issue Oct 17, 2024 that may be closed by this pull request
@HuanzhiMao HuanzhiMao changed the title Resolved Issue #702 by Adding Contibution.md file Add Contibution.md file Oct 17, 2024
@Parth4git
Copy link
Author

Parth4git commented Oct 17, 2024

@HuanzhiMao why my PR is not merged . Is there any problem. @ShishirPatil

Copy link
Owner

@ShishirPatil ShishirPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Parth4git Just make sure you move it to the right path, and rest looks good to me. Although, I wonder how much of this is a repeat of the README in the APIZoo? Do you mind highlighting what's the additional benefit of having this as opposed to including this in the APIZoo README itself?

@@ -0,0 +1,167 @@
# Contribution Guide for Gorilla API Store
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey if the contribution focus is on API Store, shouldn't this be part of the APIZoo subdorectory?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I didn't get what changes I have do . Please explain where should I have move changes. @ShishirPatil sir

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to include contribution section in readme file . Or want change in content added in contribution.md file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Contribution.md file
3 participants