-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Contibution.md file #707
base: main
Are you sure you want to change the base?
Conversation
@HuanzhiMao why my PR is not merged . Is there any problem. @ShishirPatil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @Parth4git Just make sure you move it to the right path, and rest looks good to me. Although, I wonder how much of this is a repeat of the README in the APIZoo? Do you mind highlighting what's the additional benefit of having this as opposed to including this in the APIZoo README itself?
@@ -0,0 +1,167 @@ | |||
# Contribution Guide for Gorilla API Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey if the contribution focus is on API Store, shouldn't this be part of the APIZoo subdorectory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I didn't get what changes I have do . Please explain where should I have move changes. @ShishirPatil sir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to include contribution section in readme file . Or want change in content added in contribution.md file
I have added contribution.md file which has all necessary information needed for doing any contribution in this repo.
kindly review my PR. @HuanzhiMao