Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pycairo #64

Merged
merged 1 commit into from
May 25, 2023
Merged

Fix pycairo #64

merged 1 commit into from
May 25, 2023

Conversation

michaelachrisco
Copy link

@michaelachrisco michaelachrisco commented May 25, 2023

Changes

  1. Upped the minor version of easy-thumbnails

Purpose

Solve issue where we are not able to install the pycairo.

Approach

We identified that pycairo was not installing from circleci here: https://app.circleci.com/pipelines/github/Shift3/dj-starter/395/workflows/f90cf0ab-6074-4c6b-8f94-b55978d779a4/jobs/419.

I sshed into the circleci box and installed the correct dependencies within Ubuntu/macOS seemed to allow the installation to go though.

This was, unfortunately, not a long term solution. So I went looking for how to find a python dependency within another dependcy. I found two tool that can help with that here:

pipdeptree let me see the dependencies here:

easy-thumbnails==2.8.1
  - django [required: >=2.2, installed: 4.1.2]
    - asgiref [required: >=3.5.2,<4, installed: 3.7.1]
      - typing-extensions [required: >=4, installed: 4.6.1]
    - sqlparse [required: >=0.2.2, installed: 0.4.4]
  - pillow [required: Any, installed: 9.1.1]
  - reportlab [required: Any, installed: 4.0.0]
    - freetype-py [required: >=2.3.0,<2.4, installed: 2.3.0]
    - pillow [required: >=9.0.0, installed: 9.1.1]
    - rlPyCairo [required: >=0.2.0,<1, installed: 0.2.0]
      - freetype-py [required: >=2.3, installed: 2.3.0]
      - pycairo [required: >=1.20.0, installed: 1.23.0]

Looks like this was taken care of in 2.8.2 and 2.8.3 on easy-thumbnails.

2.8.3 (2022-08-02)

    Fix regression in library detection introduced in version 2.8.2.

2.8.2 (2022-07-31)

    Installation of easy-thumbnails now optionally depends on the reportlab library.

So I upped to the newest version 2.8.5 and the installation went through.

Pre-Testing TODOs

  • Pull down this branch
  • Set up cookie cutter project

Testing Steps

  1. install the project
  2. Test out UI and see if easy-thumbnails caused any breakages.

Learning

I would heavily suggest testing this out as I did not get a chance to test out the UI and how it looks after this change. Please check the thumbnails.

We may also want this to be a hotfix since it seems to affect all branches off development/main. Just let me know and I can make this merge into main.

Closes #65

@michaelachrisco michaelachrisco changed the base branch from main to develop May 25, 2023 02:01
@michaelachrisco michaelachrisco self-assigned this May 25, 2023
@michaelachrisco michaelachrisco added the bug Something isn't working label May 25, 2023
@michaelachrisco michaelachrisco requested a review from a team May 25, 2023 16:51
@michaelachrisco michaelachrisco changed the title [WIP] Fix pycairo Fix pycairo May 25, 2023
Copy link

@fluturecode fluturecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@michaelachrisco michaelachrisco requested review from a team, suchprogramming, Wosen100 and Richie559 and removed request for a team May 25, 2023 19:58
Copy link
Contributor

@joshwingreene joshwingreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything related to images worked as expected. Thank you for taking care of this.

@michaelachrisco michaelachrisco merged commit 6d52b1f into develop May 25, 2023
@michaelachrisco michaelachrisco deleted the fix-pycairo branch May 25, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants