Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
easy-thumbnails
Purpose
Solve issue where we are not able to install the pycairo.
Approach
We identified that pycairo was not installing from circleci here: https://app.circleci.com/pipelines/github/Shift3/dj-starter/395/workflows/f90cf0ab-6074-4c6b-8f94-b55978d779a4/jobs/419.
I sshed into the circleci box and installed the correct dependencies within Ubuntu/macOS seemed to allow the installation to go though.
This was, unfortunately, not a long term solution. So I went looking for how to find a python dependency within another dependcy. I found two tool that can help with that here:
pipdeptree
let me see the dependencies here:Looks like this was taken care of in 2.8.2 and 2.8.3 on easy-thumbnails.
So I upped to the newest version 2.8.5 and the installation went through.
Pre-Testing TODOs
Testing Steps
Learning
I would heavily suggest testing this out as I did not get a chance to test out the UI and how it looks after this change. Please check the thumbnails.
We may also want this to be a hotfix since it seems to affect all branches off
development
/main
. Just let me know and I can make this merge intomain
.Closes #65