Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-square render resolutions (width != height) #96

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lasagnaphil
Copy link

This is a working draft of a PR that adds support for rasterizing to images of non-square size (width != height).

I've modified the CUDA kernels and C++ functions, changed the Rasterizer class to accept (width, height) tuple for image_size, and have confirmed that demo_render.py is working with other image sizes. I've yet not tested the other demos though, and there might be other places in the Python API that I've missed that needs to be changed as well.

This effectively solves issue #34.

The things left to do:

  • Add support for non-square image sizes in C++/CUDA land
  • Rasterizer class accepts (width, height) tuple for image_size parameter
  • Modify other places in the Python API (such as the Camera class) to also work with non-square resolution
  • Check if all Python demos are working as expected (even with different image resolutions)

Since I have limited spare time, any help on completing this PR can be appreciated (especially modifying and testing it on the Python API side).

@lasagnaphil lasagnaphil marked this pull request as draft December 16, 2021 12:32
@lasagnaphil lasagnaphil mentioned this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant