Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup processor and parser #6

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Conversation

Sheikah45
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 60.28369% with 224 lines in your changes are missing coverage. Please review.

Project coverage is 64.73%. Comparing base (886c636) to head (0b9385e).
Report is 2 commits behind head on main.

Current head 0b9385e differs from pull request most recent head b3143d5

Please upload reports for the commit b3143d5 to get more accurate results.

Files Patch % Lines
...processor/internal/resolve/ExpressionResolver.java 27.27% 110 Missing and 2 partials ⚠️
.../fx2j/processor/internal/resolve/TypeResolver.java 63.33% 29 Missing and 15 partials ⚠️
...fx2j/processor/internal/resolve/ValueResolver.java 63.85% 21 Missing and 9 partials ⚠️
...x2j/processor/internal/resolve/MethodResolver.java 77.67% 20 Missing and 5 partials ⚠️
...o/github/sheikah45/fx2j/parser/property/Value.java 66.66% 2 Missing and 2 partials ⚠️
...2j/parser/attribute/InstancePropertyAttribute.java 0.00% 1 Missing and 1 partial ⚠️
...5/fx2j/parser/element/InstancePropertyElement.java 0.00% 1 Missing and 1 partial ⚠️
...github/sheikah45/fx2j/processor/FxmlProcessor.java 80.00% 1 Missing and 1 partial ⚠️
...fx2j/parser/attribute/StaticPropertyAttribute.java 0.00% 1 Missing ⚠️
...h45/fx2j/parser/element/StaticPropertyElement.java 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #6      +/-   ##
============================================
+ Coverage     64.00%   64.73%   +0.72%     
- Complexity      295      425     +130     
============================================
  Files            20       50      +30     
  Lines          1417     2053     +636     
  Branches        182      214      +32     
============================================
+ Hits            907     1329     +422     
- Misses          431      609     +178     
- Partials         79      115      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sheikah45 Sheikah45 merged commit 2901c85 into main Jun 3, 2024
3 checks passed
@Sheikah45 Sheikah45 deleted the cleanup-processor-and-parser branch June 3, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant