Some quality changes

ShahriarDhruvo · Feb 7, 2021 · 4a448e3 · 4a448e3
1 parent 57562f9
commit 4a448e3
Show file tree

Hide file tree

Showing 14 changed files with 29 additions and 35 deletions.
diff --git a/README.md b/README.md
@@ -10,11 +10,11 @@ In this lockdown our <b>Hands-on Laboratory Activities</b> are suffering the mos
 <br /> <br />
 So, as the major part of our <i>ClassPortal</i> we tried to solve this issue by introducing <b>Interactive Simulation</b> in our project.
 
-![alt text](https://github.com/ShahriarDhruvo/HackTheVerse_SUST_NOOBs/blob/main/Cell_Simulation_Screenshots/Screenshot%20(150).png?raw=true)
+![alt text](https://github.com/ShahriarDhruvo/HackTheVerse_SUST_NOOBs/blob/main/screenshots/Screenshot%20(150).png?raw=true)
 
-![alt text](https://github.com/ShahriarDhruvo/HackTheVerse_SUST_NOOBs/blob/main/Cell_Simulation_Screenshots/Screenshot%20(154).png?raw=true)
+![alt text](https://github.com/ShahriarDhruvo/HackTheVerse_SUST_NOOBs/blob/main/screenshots/Screenshot%20(154).png?raw=true)
 
-![alt text](https://github.com/ShahriarDhruvo/HackTheVerse_SUST_NOOBs/blob/main/Cell_Simulation_Screenshots/Screenshot%20(155).png?raw=true)
+![alt text](https://github.com/ShahriarDhruvo/HackTheVerse_SUST_NOOBs/blob/main/screenshots/Screenshot%20(155).png?raw=true)
 
 # How to run this project
 1. Install the dependencies in server/requirements.txt

diff --git a/frontend/src/components/CreateCourse/CreateCourse.js b/frontend/src/components/CreateCourse/CreateCourse.js
@@ -29,7 +29,7 @@ function CreateCourse() {
     const [courses, setCourses] = useState(null);
     //const [select_course, set_select_course] = useState(null);
     //const [created_rooms, set_Created_rooms] = useState([]);
-    const [errors, seterrors] = useState('')
+    const [errors, seterrors] = useState("");
     const handleClose = () => setShow(false);
     const handleShow = () => setShow(true);
 
@@ -77,7 +77,6 @@ function CreateCourse() {
                 });
         };
         fetchuserrooms();*/
-
     }, []);
 
     const handle_course_create = (e, data) => {
@@ -96,7 +95,7 @@ function CreateCourse() {
                     //console.log(response.data);
                 })
                 .catch((err) => {
-                    seterrors('The item from this course is already created')
+                    seterrors("The item from this course is already created");
                 });
         };
         create_room();
@@ -107,11 +106,11 @@ function CreateCourse() {
             courses.length > 0 &&
             courses.map((item, i) => {
                 //if(!created_rooms.includes(item.id)){
-                    return (
-                        <option key={i} value={item.id}>
-                            {item.title}
-                        </option>
-                    );
+                return (
+                    <option key={i} value={item.id}>
+                        {item.title}
+                    </option>
+                );
                 //}
             });
         return (
@@ -128,9 +127,9 @@ function CreateCourse() {
                         <h2 className="text-center ccourse__heading">
                             Create Room
                         </h2>
-                        {Object.keys(errors).length !==0 ? (
+                        {Object.keys(errors).length !== 0 && (
                             <CustomAlert status={JSON.stringify(errors)} />
-                        ):(<p></p>)}
+                        )}
                         <Form
                             ref={form}
                             className="form"
@@ -177,7 +176,6 @@ function CreateCourse() {
                             Cancel
                         </Button>
                     </Modal.Footer>
-
                 </Modal>
             </>
         );

diff --git a/frontend/src/components/Footer/Footer.js b/frontend/src/components/Footer/Footer.js
@@ -10,7 +10,7 @@ const Footer = () => {
             <ul className="list-inline social">
                 <li className="list-inline-item clink">
                     <a
-                        href="#"
+                        href="/"
                         target="_blank"
                         rel="noopener noreferrer"
                         className="social-icon"
@@ -21,7 +21,7 @@ const Footer = () => {
 
                 <li className="list-inline-item clink">
                     <a
-                        href="#"
+                        href="/"
                         target="_blank"
                         rel="noopener noreferrer"
                         className="social-icon"
@@ -32,7 +32,7 @@ const Footer = () => {
 
                 <li className="list-inline-item clink">
                     <a
-                        href="#"
+                        href="/"
                         target="_blank"
                         rel="noopener noreferrer"
                         className="social-icon"
@@ -43,7 +43,7 @@ const Footer = () => {
 
                 <li className="list-inline-item clink">
                     <a
-                        href="#"
+                        href="/"
                         target="_blank"
                         rel="noopener noreferrer"
                         className="social-icon"
@@ -54,7 +54,7 @@ const Footer = () => {
 
                 <li className="list-inline-item clink">
                     <a
-                        href="#"
+                        href="/"
                         target="_blank"
                         rel="noopener noreferrer"
                         className="social-icon"

diff --git a/frontend/src/components/Navbar/Navbar.js b/frontend/src/components/Navbar/Navbar.js
@@ -22,19 +22,17 @@ const Navs = () => {
     return (
         <Navbar bg="" variant="light" className="nav">
             <Navbar.Brand href="#home" className="nav__brand">
-                <div>
-                    <Link to={`/`}>
-                        <img
-                            src={"/static/img/logo.png"}
-                            width={"40"}
-                            height={"40"}
-                            className={"d-inline-block align-top"}
-                            className="nav__logo"
-                            alt={"logo"}
-                        />
-                        <span className="nav__heading">ClassPortal</span>
-                    </Link>
-                </div>
+                <Link to={`/`}>
+                    <img
+                        src={"/static/img/logo.png"}
+                        width={"40"}
+                        height={"40"}
+                        className={"d-inline-block align-top"}
+                        className="nav__logo"
+                        alt={"logo"}
+                    />
+                    <span className="nav__heading">ClassPortal</span>
+                </Link>
             </Navbar.Brand>
 
             {!localStorage.getItem("isAuthenticated") ? (
@@ -66,7 +64,7 @@ const Navs = () => {
                                 style={{ fontSize: "1.09rem" }}
                                 icon={["fab", "unity"]}
                             />
-                            <span className="font-weight-bold">
+                            <span className="d-none d-md-inline font-weight-bold">
                                 Simulations
                             </span>
                         </NavLink>

diff --git a/...mulation_Screenshots/Screenshot (146).png → screenshots/Screenshot (146).png b/...mulation_Screenshots/Screenshot (146).png → screenshots/Screenshot (146).png
diff --git a/...mulation_Screenshots/Screenshot (148).png → screenshots/Screenshot (148).png b/...mulation_Screenshots/Screenshot (148).png → screenshots/Screenshot (148).png
diff --git a/...mulation_Screenshots/Screenshot (150).png → screenshots/Screenshot (150).png b/...mulation_Screenshots/Screenshot (150).png → screenshots/Screenshot (150).png
diff --git a/...mulation_Screenshots/Screenshot (151).png → screenshots/Screenshot (151).png b/...mulation_Screenshots/Screenshot (151).png → screenshots/Screenshot (151).png
diff --git a/...mulation_Screenshots/Screenshot (152).png → screenshots/Screenshot (152).png b/...mulation_Screenshots/Screenshot (152).png → screenshots/Screenshot (152).png
diff --git a/...mulation_Screenshots/Screenshot (153).png → screenshots/Screenshot (153).png b/...mulation_Screenshots/Screenshot (153).png → screenshots/Screenshot (153).png
diff --git a/...mulation_Screenshots/Screenshot (154).png → screenshots/Screenshot (154).png b/...mulation_Screenshots/Screenshot (154).png → screenshots/Screenshot (154).png
diff --git a/...mulation_Screenshots/Screenshot (155).png → screenshots/Screenshot (155).png b/...mulation_Screenshots/Screenshot (155).png → screenshots/Screenshot (155).png
diff --git a/server/db.sqlite3 b/server/db.sqlite3
diff --git a/server/server/.gitignore b/server/server/.gitignore