Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TitleState Cleanup #15256

Closed
wants to merge 6 commits into from
Closed

TitleState Cleanup #15256

wants to merge 6 commits into from

Conversation

CobaltBar
Copy link
Contributor

@CobaltBar CobaltBar commented Aug 6, 2024 •
edited
Loading

Moved all variables to the top
Changed allowedKeys to a regex

Generally made things neater

@CobaltBar CobaltBar changed the title Title Rewrite TitleState Rewrite Aug 6, 2024
tposejank
tposejank approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@tposejank tposejank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peak

@CobaltBar
Copy link
Contributor Author

Made more progress but I cant push for a few hours

@CobaltBar CobaltBar marked this pull request as ready for review August 7, 2024 00:24
@CobaltBar CobaltBar changed the title TitleState Rewrite TitleState Cleanup Aug 10, 2024
@CobaltBar CobaltBar closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tposejank tposejank tposejank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CobaltBar @tposejank