fix: Apply suggestions from code review

Co-authored-by: William Edwards <[email protected]>

src/drivers/horipad_steam/hid_report_test.rs

@@ -8,7 +8,7 @@ use super::hid_report::PackedInputDataReport;
 async fn test_horipad_steam() -> Result<(), Box<dyn Error>> {
     let report = PackedInputDataReport::unpack_from_slice(&DATA_A).unwrap();
     println!("{report}");
-    assert_eq!(report.a, true);
+    assert!(report.a, "should be pressed");
 
     Ok(())
 }

src/drivers/horipad_steam/mod.rs

@@ -1,5 +1,6 @@
 pub mod driver;
 pub mod event;
 pub mod hid_report;
+#[cfg(test)]
 pub mod hid_report_test;
 pub mod report_descriptor;

src/input/source/hidraw.rs

@@ -20,7 +20,7 @@ use crate::{
     constants::BUS_SOURCES_PREFIX,
     drivers,
     input::composite_device::client::CompositeDeviceClient,
-    udev::device::{self, UdevDevice},
+    udev::device::UdevDevice,
 };
 
 use self::{

src/input/source/hidraw/horipad_steam.rs

@@ -13,7 +13,7 @@ use crate::{
     udev::device::UdevDevice,
 };
 
-/// XpadUhid source device implementation
+/// HoripadSteam source device implementation
 pub struct HoripadSteam {
     driver: Driver,
 }
@@ -45,7 +45,7 @@ impl SourceInputDevice for HoripadSteam {
 
 impl Debug for HoripadSteam {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        f.debug_struct("XpadUhid").finish()
+        f.debug_struct("HoripadSteam").finish()
     }
 }
 

src/input/source/mod.rs

@@ -9,7 +9,7 @@ use ::evdev::FFEffectData;
 use thiserror::Error;
 use tokio::sync::mpsc::{self, error::TryRecvError};
 
-use crate::udev::device::{self, UdevDevice};
+use crate::udev::device::UdevDevice;
 
 use self::{
     client::SourceDeviceClient, command::SourceCommand, evdev::EventDevice, hidraw::HidRawDevice,