Refactor function into class

SethO · Oct 31, 2023 · 9951b88 · 9951b88
1 parent 0f025ac
commit 9951b88
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/lib/keyValueRepository.ts b/lib/keyValueRepository.ts
@@ -118,7 +118,7 @@ class KeyValueRepository {
   }
 
   async update(item: any) {
-    validateHashKeyPropertyExists({ item, keyName: this.keyName });
+    this.validateHashKeyPropertyExists(item);
     const { revision: previousRevision } = item;
     const itemToSave = setRepositoryModifiedProperties(item);
     const putParams: PutCommandInput = {
@@ -160,7 +160,7 @@ class KeyValueRepository {
   }
 
   async updatePartial(item: any): Promise<Record<string, any>> {
-    validateHashKeyPropertyExists({ item, keyName: this.keyName });
+    this.validateHashKeyPropertyExists(item);
     const updateInput = this.buildUpdateCommandInput(item);
     let result: UpdateCommandOutput;
     try {
@@ -211,6 +211,12 @@ class KeyValueRepository {
 
     return updateInput;
   }
+
+  private validateHashKeyPropertyExists(item: any) {
+    if (!item[this.keyName]) {
+      throw new BadRequest(`Bad Request: Item has no key named "${this.keyName}"`);
+    }
+  }
 }
 
 const isNotFoundConflict = (itemFromError?: any) => !itemFromError;
@@ -221,13 +227,6 @@ const isRevisionConflict = (input: { expectedRevision: number; actualRevision: n
   return expectedRevision !== actualRevision;
 };
 
-const validateHashKeyPropertyExists = (input: { item: any; keyName: string }) => {
-  const { item, keyName } = input;
-  if (!item[keyName]) {
-    throw new BadRequest(`Bad Request: Item has no key named "${keyName}"`);
-  }
-};
-
 const setRepositoryModifiedProperties = (item: any) => {
   const returnItem = { ...item };
   returnItem.updatedAt = new Date().toISOString();

diff --git a/test/updatePartial.int.test.ts b/test/updatePartial.int.test.ts
@@ -11,7 +11,7 @@ import getDocumentClient from './documentClient';
 const TableName = 'HashKeyTestDB';
 const KeyName = 'key';
 
-describe('When updating an item', () => {
+describe('When partially updating an item', () => {
   const testKeys: string[] = [];
   const documentClient = getDocumentClient();