-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to ubuntu 22.04 #70
base: master
Are you sure you want to change the base?
Conversation
Why would we want to switch to ubuntu? |
FWIW, I forked this Ubuntu branch (thanks!) because I wanted to make winbindd work and join a Samba domain--and this is basically impossible with Alpine (or used to be). Those commits on my branch are late, I've been running it like this for 8 months and it works pretty well. But unfortunately Alpine was not an option. |
good to know, I was thinking about creating an enhanced DC samba controller container - but if you mention it's troublesome with alpine I will postpone this project :D |
HEALTHCHECK --interval=60s --timeout=15s \ | ||
CMD smbclient -L \\localhost -U % -m SMB3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarvAmBass, you might want to update the healthcheck to smbclient -L //localhost -U %
. I suggest to remove -m SMB3
, as the user might disable SMBv3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, but I didn't use smbclient for healthchecking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I just wanted to suggest to use it. YMMV 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, it thought the same, that it's a bit better than my current healthcheck - I'll think about it :)
I'm not going to fork this, but maybe anyone is interested in is fork/work :)