Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Blu-Ray ISOs #1

Open
wants to merge 2 commits into
base: 4.7-servarr
Choose a base branch
from

Conversation

Flygsand
Copy link

This PR adds FFProbe support for Blu-Ray ISOs and pertains to Radarr/Radarr#7828. ffprobe is sometimes able to pull incomplete media info if an ISO file is passed directly, but often fails as illustrated in the aforementioned issue. The bluray protocol allows ffprobe to reliably pull information from ISO images, raw devices and folders using libbluray. FFmpeg needs to be built with --enable-libbluray --enable-protocol=bluray for this to work. I'm currently looking into it.

For the tests, I authored a small Blu-Ray ISO image. ffprobe will ignore playlists shorter than 3 minutes in length, which is why this length was chosen. The image deflates down to about 1.4 MiB and was made using public domain video and audio.

I've never coded in C# or used Visual Studio before, so please bear with me :).

@Flygsand
Copy link
Author

Flygsand commented Jan 2, 2023

@Qstick could you please take a look at this PR, as well as Servarr/ffmpeg-build#9, and let me know what you think?

@Qstick
Copy link
Member

Qstick commented Jan 9, 2023

Can you rebase this to 4.7-sevarr.. 4.8 branch has some issues and thus we aren't yet running it on the apps.

@Flygsand Flygsand changed the base branch from 4.8-servarr to 4.7-servarr January 9, 2023 12:22
@Flygsand
Copy link
Author

Flygsand commented Jan 9, 2023

Done.

@Qstick
Copy link
Member

Qstick commented Jan 9, 2023

One question, we get quit a bit of errors due to FFProbe failing on DVDR releases (img files) due to finding codec GEM Raster Image.

Are these handled better or correctly with this bluray code? If not we need to look at deciding when to prefix bluray on IMG files as it could be either.

@Flygsand
Copy link
Author

Good catch. I hadn't considered DVDs at all. 🤦

Are these handled better or correctly with this bluray code?

They are not. Sadly, there doesn't seem to exist similar support for DVDs in FFmpeg (although the idea appears to have surfaced a couple of times on their mailing list).

Could we maybe extend the FFProbe API to accept a "hint" as to the type of media we expect to be dealing with, and pass in whatever we've learned from parsing the release title? This would then apply to ISOs and IMGs.

@Flygsand
Copy link
Author

As as suggestion to the above, I've extended the FFProbe API to accept URIs that can either be regular media files or Blu-Rays.

Used here: Flygsand/Radarr@a8d215d

@Flygsand
Copy link
Author

Flygsand commented Feb 21, 2023

Could we have another look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants