-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Blu-Ray ISOs #1
base: 4.7-servarr
Are you sure you want to change the base?
Conversation
@Qstick could you please take a look at this PR, as well as Servarr/ffmpeg-build#9, and let me know what you think? |
Can you rebase this to |
9a470fb
to
2ad7d08
Compare
Done. |
One question, we get quit a bit of errors due to FFProbe failing on DVDR releases (img files) due to finding codec GEM Raster Image. Are these handled better or correctly with this bluray code? If not we need to look at deciding when to prefix bluray on IMG files as it could be either. |
Good catch. I hadn't considered DVDs at all. 🤦
They are not. Sadly, there doesn't seem to exist similar support for DVDs in FFmpeg (although the idea appears to have surfaced a couple of times on their mailing list). Could we maybe extend the |
As as suggestion to the above, I've extended the FFProbe API to accept URIs that can either be regular media files or Blu-Rays. Used here: Flygsand/Radarr@a8d215d |
Could we have another look at this? |
This PR adds FFProbe support for Blu-Ray ISOs and pertains to Radarr/Radarr#7828.
ffprobe
is sometimes able to pull incomplete media info if an ISO file is passed directly, but often fails as illustrated in the aforementioned issue. The bluray protocol allowsffprobe
to reliably pull information from ISO images, raw devices and folders using libbluray. FFmpeg needs to be built with--enable-libbluray --enable-protocol=bluray
for this to work. I'm currently looking into it.For the tests, I authored a small Blu-Ray ISO image.
ffprobe
will ignore playlists shorter than 3 minutes in length, which is why this length was chosen. The image deflates down to about 1.4 MiB and was made using public domain video and audio.I've never coded in C# or used Visual Studio before, so please bear with me :).