-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved existing tests and implemented new tests #123
Open
nanoandrew4
wants to merge
24
commits into
Sergix:dev
Choose a base branch
from
nanoandrew4:unittests
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View changelog entry Sergix#116 and the associated documentation for details.
TODO: Fix broken links
Removed unnecessary throws in initWindows function Sergix#120
…ds to the underlying system (currently only Unix/bash commands are supported), and reading/writing a history file similar to bash_history. The ported code also includes more documentation, which will be expanded on
…ed custom command running to enable custom commands previously implemented by JTerm
…y did previously, though more in depth tests are pending
# Conflicts: # src/main/java/jterm/JTerm.java # src/main/java/jterm/command/Dir.java # src/main/java/jterm/command/Exec.java # src/main/java/jterm/command/Files.java # src/main/java/jterm/command/Ping.java # src/main/java/jterm/io/input/InputHandler.java # src/main/java/jterm/io/input/Keys.java # src/main/java/jterm/io/output/CollectorPrinter.java # src/main/java/jterm/io/output/GuiPrinter.java # src/main/java/jterm/io/output/HeadlessPrinter.java # src/main/java/jterm/io/output/Printer.java # src/test/java/jterm/io/InputHandlerTest.java # src/test/java/jterm/util/UtilUnitTest.java
…travis.yml to support UI testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on the ezcli backport (#124), so that PR should be merged before this one.
This PR adds more tests to test code from the backport, as well as existing code, to raise code coverage. The initial target was >50% but I ended up leaving it at 39% for now since the rest of the code is very hard or impossible to test. Test libraries are also replace, JUnit Jupiter was used before, which has been replaced with JUnit, and Mockito was added since it is used in new tests.
All tests were verified as passing in my local environment.