Terminalsettings: Optimize TerminalSettings config writes and fix cancel behavior for m_automark_mode
#25388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved an issue in TerminalSettings where changes to `m_automark_mode` would persist even when the user clicked "Cancel." This fix ensures that selecting "Cancel" properly reverts any modifications made to `m_automark_mode`.
Eliminated unnecessary duplicate writes to the config file in TerminalSettings. Previously, settings were saved both immediately after a user changed them and again when they clicked "Apply," "Cancel," or "OK." Now, settings are only written once to improve efficiency.
github-actions
bot
added
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: