Cherry-pick "Tests: Use .invalid TLD for invalid requests" #25134
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
RFC2606 and RFC6761 define .invalid as a guaranteed-invalid TLD, so let's use it. Theoretically this should make the request fail much faster. (cherry picked from commit ea95e325390cefd4e1289e8c3de6b56d2c34473f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC2606 and RFC6761 define .invalid as a guaranteed-invalid TLD, so let's use it. Theoretically this should make the request fail much faster.
(cherry picked from commit ea95e325390cefd4e1289e8c3de6b56d2c34473f)
LadybirdBrowser/ladybird#1597