Use INT64_MAX instead of UINT64_MAX for overflow checks

SequentiaSEQ · Apr 24, 2024 · 8d64eb8 · 8d64eb8
1 parent d3911fd
commit 8d64eb8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/exchangerates.cpp b/src/exchangerates.cpp
@@ -14,10 +14,11 @@ CAmount ExchangeRateMap::CalculateExchangeValue(const CAmount& amount, const CAs
     }
     auto scaled_value = it->second.m_scaled_value;
     __uint128_t value = ((__uint128_t)amount * (__uint128_t)scaled_value) / (__uint128_t)exchange_rate_scale;
-    if (value > UINT64_MAX) {
-        return UINT64_MAX;
+    int64_t int64_max = std::numeric_limits<int64_t>::max();
+    if (value > int64_max) {
+        return int64_max;
     } else {
-        return (uint64_t) value;
+        return (int64_t) value;
     }
 }