Add fix wrong agent import command #165
Conversation
|
|
||
| # Move files and directories from the versioned folder to the root action directory | ||
| for item in temp_extract_path.rglob("*"): | ||
| if item.is_file(): |
There was a problem hiding this comment.
I think that there's a metadata json which should be ignored here too (not just the one from the agent package).
There was a problem hiding this comment.
I didn't see any while building zip and then extracting it but I guess it could happen in other scenarios, will include that exclusion
There was a problem hiding this comment.
There's no real issue, the only problem is that this metadata file will become outdated as the user changes the code (the metadata is created in the zip when the action package is created and shouldn't be shown when it's extracted later on).
|
|
||
| # Move files and directories from the versioned folder to the root action directory | ||
| for item in temp_extract_path.rglob("*"): | ||
| if item.is_file() and item.name != "metadata.json": |
There was a problem hiding this comment.
This isn't the proper name of the json. I don't remember now the exact name, but you should be able to check it when you build the action package in the test (please also fix the test to check for this exclusion).
Stable release checklist:
python -m dev set-version {version}/docs/changelog.mdwith the changes for the releasePre-release checklist:
/docs/changelog.mdwith the new changes.