Show datasource configuration status #163
Conversation
| return; | ||
| } | ||
|
|
||
| this.globalDataSourceState.clear(); |
There was a problem hiding this comment.
You don't want to clear the previous values, rather you want to compare and if the values change then you'll call fireRootChange.
sema4ai/vscode-client/src/views.ts
Outdated
| @@ -232,6 +232,11 @@ export function registerViews(context: ExtensionContext) { | |||
| "treeDataProvider": robotsTreeDataProvider, | |||
| }); | |||
|
|
|||
| // Periodic refresh every 60 seconds | |||
| setInterval(() => { | |||
There was a problem hiding this comment.
Let's not poll for now and instead call robotsTreeDataProvider.updateDatasourceStatuses() (without waiting) in the following situations:
-
when the root element (undefined) is asked in
async getChildren(element?: RobotEntry): Promise<RobotEntry[]> {-- inviewsRobots.ts. -
Whenever we drop or setup a data source or we finish awaiting for a model to be trained.
Please create a separate function for that as we may want to do more things (such as notifying the data extension when these things happen).
| let isConfigured = dataSourcesFromActionPackage?.get(dbName)?.configured; | ||
|
|
||
| let name = `${dbName} ?`; | ||
| if (isConfigured !== undefined) { |
There was a problem hiding this comment.
We should also show the training state (when it's a model).
Stable release checklist:
python -m dev set-version {version}/docs/changelog.mdwith the changes for the releasePre-release checklist:
/docs/changelog.mdwith the new changes.