Improvements

docs/changelog.md

@@ -1,5 +1,6 @@
 ## Unreleased
 
+- Add setup support for external data sources
 - Add `sema4ai.dropDataSource` command
 - Add Datasources to the UI
 - Add `sema4ai.getActionsMetadata` command

sema4ai/vscode-client/src/robo/dataSourceHandling.ts

@@ -1,19 +1,13 @@
 import { Uri, window, commands } from "vscode";
-import { OUTPUT_CHANNEL } from "../channel";
+import { logError, OUTPUT_CHANNEL } from "../channel";
 import { RobotEntry } from "../viewsCommon";
 import { DatasourceInfo } from "../protocols";
 import { langServer } from "../extension";
 import { startDataServerAndGetInfo } from "../dataExtension";
 
 function isExternalDatasource(datasource: DatasourceInfo): boolean {
     const externalEngines = ["custom", "files", "models"];
-    const isEngineExternal =
-        !externalEngines.includes(datasource.engine) && !datasource.engine.startsWith("prediction");
-
-    const isMissingModelAndTable =
-        !datasource.model_name && !datasource.created_table && datasource.engine !== "custom";
-
-    return isEngineExternal || isMissingModelAndTable;
+    return !externalEngines.includes(datasource.engine) && !datasource.engine.startsWith("prediction");
 }
 
 export const setupDataSource = async (entry?: RobotEntry) => {
@@ -38,7 +32,8 @@ export const setupDataSource = async (entry?: RobotEntry) => {
         try {
             await commands.executeCommand("sema4ai-data.database.add");
         } catch (e) {
-            window.showErrorMessage("Could not run setup command. Make sure you have a data server active.");
+            logError("Could not run setup data source command", e, "ERR_DATA_SOURCE_SETUP");
+            window.showErrorMessage(`"Could not run setup data source command: ${e.message}"`);
         }
 
         return;