Fix to ensure older tensorflow versions still work #858
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing two type annotations for
tf.keras.optimizers.legacy.Optimizer
to forward references sincetf.keras.optimizers.legacy
doesn't exist in older (<2.9?) tensorflow versions. This resulted in the following error:We could define new type aliases like
OptimizersTF
inalibi_detect/utils/_types.py
, but it seems to be overly complicating things to me (we'd need three groups, one containing classes only, one types only, and one containing both...). We're also already using forwardref's for the tensorflow optimizers in other places...P.s. have tested this with
tensorflow == 2.8
and the error no longer occurs (when it does withmaster
).