Add Japanese language dependencies #1511

jbauer2718 · 2023-12-12T19:36:38Z

Resolves #1506

jyono

great work! this is really giving my team trouble. would love to see this merged.

sakoush

Many thanks for your contribution, I left some comments. I suggest that these extra libraries are optional as they are not required for all cases. Also I left some suggestions to tidy up the tests.

runtimes/huggingface/pyproject.toml

runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py

jbauer2718 · 2023-12-14T00:38:50Z

@sakoush I believe I have addressed your comments. Let me know if I have misunderstood something!

sakoush

Thanks for acting on the suggestions, I left a minor suggestion to parametrise the test case.

Also could you please update the huggingface runtime docs with to explain how to use your addition?

runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py

sakoush

Thanks for the contribution so far, I left a few minor suggestions.

Apologies for the slow response due to the holiday season.

docs/examples/huggingface/README.md

runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py

…case.

jbauer2718 · 2024-01-11T06:16:28Z

@sakoush Hey! Hope your holidays went well. Just bumping this to your attention because I think it's ready if not close to ready to merge. Let me know if I misunderstood some of your comments. Looking forward to your feedback.

sakoush

Many thanks for the contribution, I left a minor doc change.

docs/examples/huggingface/README.md

sakoush

lgtm

jbauer2718 · 2024-01-17T19:56:24Z

Hey @sakoush , the pipeline is failing on TF v2.14 dropping support for Python 3.8. Would you rather drop support for Python 3.8 for this runtime or have me deprecate TF to v2.13?

…ldonIO#1692) Bumps [joblib](https://github.com/joblib/joblib) from 1.3.2 to 1.4.0. - [Release notes](https://github.com/joblib/joblib/releases) - [Changelog](https://github.com/joblib/joblib/blob/main/CHANGES.rst) - [Commits](joblib/joblib@1.3.2...1.4.0) --- updated-dependencies: - dependency-name: joblib dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…eldonIO#1695) Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](pandas-dev/pandas@v2.2.1...v2.2.2) --- updated-dependencies: - dependency-name: pandas dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

sakoush · 2024-04-16T14:45:30Z

@jbauer2718 it looks like that merge conflicts have not been resolved correctly, at least by looking at the changes in docs/examples/huggingface/README.md

…case.

jbauer2718 · 2024-04-16T17:55:08Z

@sakoush Sorry for missing that. Should be good now.

CLAassistant · 2024-05-22T17:35:05Z

All committers have signed the CLA.

jbauer2718 added 3 commits December 12, 2023 17:54

Added Japanese dependencies to mlserver-huggingface

4e49666

Added unit test for Japanese server

e6562e1

linted

4414ccf

jyono approved these changes Dec 12, 2023

View reviewed changes

sakoush requested changes Dec 12, 2023

View reviewed changes

Addressed style comments; made dependencies optional

399d83b

jbauer2718 requested a review from sakoush December 14, 2023 16:18

sakoush requested changes Dec 15, 2023

View reviewed changes

runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py Outdated Show resolved Hide resolved

jbauer2718 added 4 commits December 15, 2023 22:57

Updated README.md and unit test

854784f

Updated docs

c6f1a4f

Working test in docs

f75ee9e

Generalized test to a list of cases

936fadf

jbauer2718 requested a review from sakoush December 16, 2023 00:10

jbauer2718 added 3 commits December 15, 2023 16:11

updated docs

5b3a258

Fixed notebook cell outputs

c30f2ad

Fixed notebook cell outputs

339527f

sakoush requested changes Dec 26, 2023

View reviewed changes

docs/examples/huggingface/README.md Outdated Show resolved Hide resolved

runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py Outdated Show resolved Hide resolved

runtimes/huggingface/tests/test_tasks/test_japanese_mask_fill.py Outdated Show resolved Hide resolved

Refactored test with pytest.pymark.parameterize. Used a smaller test …

f44656d

…case.

jbauer2718 requested a review from sakoush December 26, 2023 17:52

Finished an inline comment I forgot to fully type out

73c60a7

sakoush reviewed Jan 16, 2024

View reviewed changes

docs/examples/huggingface/README.md Outdated Show resolved Hide resolved

docs/examples/huggingface/README.md Outdated Show resolved Hide resolved

jbauer2718 added 3 commits January 16, 2024 10:02

Updated lock and docs

2715c2b

Removed .bak.ipynb

2a9652b

Updated README.ipynb to match README.md

8992881

jbauer2718 requested a review from sakoush January 16, 2024 19:45

jyono approved these changes Jan 16, 2024

View reviewed changes

sakoush approved these changes Jan 17, 2024

View reviewed changes

dependabot bot added 2 commits April 16, 2024 10:53

jbauer2718 and others added 25 commits April 16, 2024 10:59

Fixed merge conflict in README

b1e7c14

Fixed merge conflict in lock

7f21db5

Rebased and fixed lock

6df3dbe

Added unit test for Japanese server

32d16e8

linted

f6a3901

Addressed style comments; made dependencies optional

47bd2da

Updated README.md and unit test

188b369

Updated docs

7fa5d0c

Working test in docs

d755990

Generalized test to a list of cases

bf4d412

updated docs

6174e00

Fixed notebook cell outputs

5f8c8e3

Fixed notebook cell outputs

3fa63e0

Refactored test with pytest.pymark.parameterize. Used a smaller test …

aafa4d1

…case.

Finished an inline comment I forgot to fully type out

549f244

Updated lock and docs

0d61961

Removed .bak.ipynb

827329f

Updated README.ipynb to match README.md

c9372a5

rebuilt lock files with same version of poetry

e137c05

Fixed merge conflict in README

d9211bf

Fixed merge conflict in lock

4a9c1c6

Fixed merge conflicts

4c63c86

Update README.md

85bddf1

removed files for bert-japanese

616d3a9

Removed model setting

cf4ec15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Japanese language dependencies #1511

Add Japanese language dependencies #1511

jbauer2718 commented Dec 12, 2023

jyono left a comment

sakoush left a comment

jbauer2718 commented Dec 14, 2023

sakoush left a comment

sakoush left a comment

jbauer2718 commented Jan 11, 2024

sakoush left a comment

sakoush left a comment

jbauer2718 commented Jan 17, 2024

sakoush commented Apr 16, 2024

jbauer2718 commented Apr 16, 2024

CLAassistant commented May 22, 2024 •

edited

Loading

Add Japanese language dependencies #1511

Are you sure you want to change the base?

Add Japanese language dependencies #1511

Conversation

jbauer2718 commented Dec 12, 2023

jyono left a comment

Choose a reason for hiding this comment

sakoush left a comment

Choose a reason for hiding this comment

jbauer2718 commented Dec 14, 2023

sakoush left a comment

Choose a reason for hiding this comment

sakoush left a comment

Choose a reason for hiding this comment

jbauer2718 commented Jan 11, 2024

sakoush left a comment

Choose a reason for hiding this comment

sakoush left a comment

Choose a reason for hiding this comment

jbauer2718 commented Jan 17, 2024

sakoush commented Apr 16, 2024

jbauer2718 commented Apr 16, 2024

CLAassistant commented May 22, 2024 • edited Loading

CLAassistant commented May 22, 2024 •

edited

Loading