Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to Django 2.2.1 & DRF 3.9 plus some other package upgrades with minor changes. #120

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kooshan75
Copy link

Fixes #115 & #111.
Upgraded almost every package to its latest release and migrated to Django 2.2.1 & DRF 3.9.
Changed two incompatible packages that the project was using them:

django-disposable-email-checker

Which did not support Django 2.2.1, I switched it to email_validator, which almost has the same functionality.

django-rest-knox==3.0.3

Which was incompatible, I switched it to a more reliable and known package called django-rest-auth and moved to its Token Authentication method.

@kooshan75 kooshan75 changed the title Upgraded to Django 2.2.1 and some other packages upgrade with minor changes. Upgraded to Django 2.2.1 & DRF 3.9 plus some other package upgrades with minor changes. Jun 4, 2019
@kooshan75
Copy link
Author

I'm also planning to complete the implementation of test files and committing them in the next couple of days since I've run tests manually.

@kooshan75
Copy link
Author

kooshan75 commented Jun 4, 2019

I'm also planning to complete the implementation of test files and committing them in the next couple of days since I've run tests manually.

Done.
All tests were successful & ./scripts/test_local_backend.sh returns that all tests have passed.
@abossard
@lfrodrigues
@pconerly
@andrealmar
@DFilipeS

I'd be honored if you guys could review my code.

@gwsampso
Copy link

gwsampso commented Jul 12, 2019

Other than the travis build failing because of #120 looks like i would be best to use this if starting a fresh project @kooshan75 ?

@kooshan75
Copy link
Author

Other than the travis build failing because of #120 looks like i would be best to use this if starting a fresh project @kooshan75 ?

Yes of course. The old version of this project doesn't support lots of services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating to more recent version of django, drf, etc.
2 participants