Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Notice severity level #1615

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

atGit2021
Copy link
Contributor

@atGit2021 atGit2021 commented Oct 30, 2024

Monday
Hiding problems with severity level of Notice temporarily per request from Sheri

Summary by CodeRabbit

  • New Features

    • Introduced a filtering mechanism to display only relevant problems based on severity in the PnPExtractionProblems component.
    • Problems with a severity of "Notice" are now excluded from the displayed list.
  • Bug Fixes

    • Enhanced problem grouping and rendering by ensuring only significant issues are processed.

@atGit2021 atGit2021 requested a review from rdonigian October 30, 2024 22:58
@atGit2021 atGit2021 self-assigned this Oct 30, 2024
@atGit2021 atGit2021 requested a review from CarsonF as a code owner October 30, 2024 22:58
Copy link
Contributor

coderabbitai bot commented Oct 30, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request introduce a filtering mechanism within the PnPExtractionProblems component to exclude problems with a severity of "Notice." A new constant, filteredProblems, is created to hold the relevant problems, and the groupToMapBy function now operates on this filtered array. The ProblemList and SeverityIcon components remain unchanged, maintaining their existing logic and structure.

Changes

File Path Change Summary
src/scenes/ProgressReports/PnpValidation/PnPExtractionProblems.tsx Added filtering for problems based on severity, excluding "Notice" severity from the displayed list.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PnPExtractionProblems
    participant ProblemList
    participant SeverityIcon

    User->>PnPExtractionProblems: Request to view problems
    PnPExtractionProblems->>PnPExtractionProblems: Filter problems (exclude "Notice")
    PnPExtractionProblems->>ProblemList: Pass filtered problems
    ProblemList->>SeverityIcon: Display severity icons
    ProblemList-->>User: Render grouped problems
Loading

🐇 "In the meadow where problems bloom,
We filter out the 'Notice' gloom.
With severity clear, we see the light,
Grouping issues, all feels right!
Hopping through code, we celebrate,
A cleaner view, oh, isn't it great?" 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 63809e2 and 35359a5.

📒 Files selected for processing (1)
  • src/scenes/ProgressReports/PnpValidation/PnPExtractionProblems.tsx (1 hunks)

@CarsonF
Copy link
Member

CarsonF commented Oct 31, 2024

The goal is to only have errors?

@atGit2021
Copy link
Contributor Author

atGit2021 commented Oct 31, 2024 via email

Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Welcome back btw!

@atGit2021
Copy link
Contributor Author

atGit2021 commented Oct 31, 2024 via email

@atGit2021 atGit2021 merged commit 06d8ce8 into develop Oct 31, 2024
5 checks passed
@atGit2021 atGit2021 deleted the PnP-Validation-Revision-For-Reporting branch October 31, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants