Temp limit Progress Reports to only Active/Completed Projects #1614
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/scenes/Dashboard/ProgressReportsWidget/ProgressReportsGrid.tsx (1)
194-198: Implementation looks good, but consider making status values configurable.The filter implementation correctly achieves the PR objective of filtering progress reports by project status. However, consider these improvements:
- Extract status values to a constant or enum to improve maintainability:
const ALLOWED_PROJECT_STATUSES = ['Active', 'Completed'] as const;
- Add a comment explaining why these specific statuses were chosen:
// Filter to show only Active and Completed projects as these are the only // statuses that should have meaningful progress reports
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
src/scenes/Dashboard/ProgressReportsWidget/ProgressReportsGrid.tsx(1 hunks)
🔇 Additional comments (1)
src/scenes/Dashboard/ProgressReportsWidget/ProgressReportsGrid.tsx (1)
194-198: Verify the impact of filtering on existing users.
Let's ensure this filtering doesn't unexpectedly hide important data from users.
✅ Verification successful
Project status filtering is consistent with existing usage
Based on the codebase analysis:
- The status filter
['Active', 'Completed']aligns with existing project status handling in the application - The filter is used in the ProgressReportsGrid context where showing only active and completed projects is logical
- Similar status filtering exists in other components (e.g.,
EngagementColumns.tsxandProjectColumns.tsx) where 'Active' status is commonly used as a filter - The UI properly handles and displays project status information through various components, suggesting this is an expected behavior
The implementation appears to be a deliberate feature rather than a potential data visibility issue.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any existing usage of project status in queries or components
# to understand the impact of this filter
# Look for other instances of project status filtering
rg -l "project.*status.*Active.*Completed" --type typescript
# Look for any comments or documentation about project status handling
rg -l "project status" --type typescript
Length of output: 175
Script:
#!/bin/bash
# Search for any existing usage of project status in queries or components
# Let's try without file type restriction and use more specific patterns
# Look for other instances of project status filtering
rg -l "project.*status.*(\['Active', 'Completed'\]|Active.*Completed)"
# Look for any GraphQL queries or types related to project status
rg -l "type.*Project.*status|query.*project.*status"
# Look for any comments or documentation about project status
rg -i "project status" -A 2 -B 2
Length of output: 566
Script:
#!/bin/bash
# Let's examine the GraphQL schema and queries to understand the project status usage
# Look for GraphQL schema definitions
rg "type.*Project.*{" -A 10
# Search for GraphQL queries or fragments that include project status
rg "query.*{|fragment.*{" -A 20 | rg -A 20 -B 5 "project.*{|status"
# Check for any filters or where conditions related to project status
rg "where.*project.*status|filter.*project.*status" -A 3 -B 3
Length of output: 480
Script:
#!/bin/bash
# Let's try with simpler patterns to understand the project status usage
# Look for GraphQL schema definitions
rg "type Project" -A 10
# Look for files containing both project and status references
rg -l "project" | xargs rg "status"
# Search for any filtering conditions
rg "where: ?{" -A 5
Length of output: 8179
CarsonF
changed the title
Until the logic to delete/not-create "useless" reports is applied in the API, we will filter them out here.
Monday
Summary by CodeRabbit
New Features
Bug Fixes