Progress Report Grid Fixes #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurred because: 1. There's a user WIP filter without a value 1a. This doesn't result in an API input change 1b. This is persisted to local storage 2. Page loads 3. -1 is set for full/unfiltered cache list 4. That same list is used for filtered cache lists (1a) 5. Since there was a previous value, that early return was being hit 6. The total on either full/unfiltered list and filtered list was never written 7. Grid never switched to client side sorting/filtering even though it did have everything
indexOf(null) -> -1 -> an actual sort value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.