Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sort and filter on progress column #1607

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

atGit2021
Copy link
Contributor

@atGit2021 atGit2021 self-assigned this Oct 15, 2024
@atGit2021 atGit2021 requested a review from CarsonF as a code owner October 15, 2024 18:59
@atGit2021 atGit2021 requested a review from rdonigian October 15, 2024 19:00
@atGit2021
Copy link
Contributor Author

@CarsonF will need your help with an ASC/DESC sort issue. When the sort arrow is clicked to ASC the API sends back the list in DESC order. When the DESC arrow is clicked it sends back the list in ASC order.

atGit2021 and others added 3 commits October 16, 2024 08:17
The varianceExplanation reason can override the status on that object.
We probably don't want that here.
@CarsonF
Copy link
Member

CarsonF commented Oct 16, 2024

API appears to sort fine to me.
I fixed the client side sorting here by ordering by index based on the API defined order (which I also just enabled SeedCompany/cord-api-v3@4beaa9d)

Also the variance reason given can override the schedule status according to the variance explanation.

varianceExplanation: {
  reasons: ["I am ahead"]
  scheduleStatus: Behind // doesn't make sense
}

So that's why we follow the reason there.

The schedule status on cumulative summary just looks at its own variance.
So that more closely follows what we want to display here I think, since the summary numbers are right next to it.

I had, and maybe you did too, picked a random reason, and was seeing "Ahead" but it wasn't sorting that way. Because the sorting just looks at the variance number, not the reasons.

@CarsonF CarsonF force-pushed the 0213-Dashboard-Filter-Sort-By-Progress branch from 373ca47 to 7298a4c Compare October 16, 2024 13:22
@CarsonF CarsonF merged commit 3fea8f9 into develop Oct 16, 2024
3 checks passed
@CarsonF CarsonF deleted the 0213-Dashboard-Filter-Sort-By-Progress branch October 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants