Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Report Grid - Expansion tweaks #1605

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Oct 14, 2024

  • Create our own useSet hook
  • Split expansion state to be independent of grid selected state
  • Allow multiple rows to be expanded
  • Add expand/collapse all buttons
  • Avoid toggling expansion when the user intends to drag instead of click
  • Avoid collapsing on double click (need to delay collapse)
  • Fix Quarter Select comparison of current value to available options

Screenshot 2024-10-14 at 10 23 49 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like functionality we'll potentially be using in other tables. It'd be more appropriate to move to /components in either it's own folder or in the Grid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially. We can definitely move when the need arises.

@CarsonF CarsonF merged commit 33c9409 into develop Oct 15, 2024
4 checks passed
@CarsonF CarsonF deleted the progress-report/expansion-tweaks branch October 15, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants