Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project workflow events from steps logic #1597

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Oct 3, 2024

This now matches what ProgressReports do

const list = events
.map((event, i) => ({
...event,
prevStatus: StatusLabels[events[i - 1]?.status ?? StatusList[0]!],
status: StatusLabels[event.status],
}))
.reverse();

It was just flat out wrong before, because we were reversing first.
I possibly could've just switch -1 to +1, which I just thought of.
Maybe what I have committed is easier to reason about though.

https://seed-company-squad.monday.com/boards/3451697530/pulses/7589694440

@CarsonF CarsonF merged commit 47522df into develop Oct 3, 2024
3 checks passed
@CarsonF CarsonF deleted the bugfix/project-workflow-events-from branch October 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant