Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak line height value #1592

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Tweak line height value #1592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/scenes/Dashboard/ProgressReportsWidget/ProgressReportsExpandedGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,12 @@ const COLLAPSED_ROW_HEIGHT = 54;
const NonExpansionCell = ({ formattedValue }: GridRenderCellParams) => (
<Box
sx={{
'--height': `${COLLAPSED_ROW_HEIGHT}px`,
// Causes row to grow by 1px on row height auto
// Shift the 1px to padding to prevent.
height: 'calc(var(--height) - 1px)',
height: COLLAPSED_ROW_HEIGHT - 1,
pt: '1px',
// This is exactly what MUI does when not auto height
lineHeight: 'calc(var(--height) - 1px)',
// Text shifts by a pixel without this - any value works
lineHeight: 1,

display: 'flex',
alignItems: 'center',
Expand Down
Loading